fix(deep-link): revert the breaking change introduced by #2928 #2970
Conversation
|
Can you log::error the error instead and add a to-do saying that we change it into an error in v3? I can't make code changes at the moment so that would help me :) I brought the Windows gen thing up as well but we didn't spot what's causing it yet (I don't think anybody really looked into it). If possible I'd prefer if you could revert those files just to be sure the docs generator won't struggle. |
|
Sure, I'll do it soon.
Do you mean to revert it back to |
|
Ah i didn't even notice that, but yes, that should be reverted as well since there are a few more places where io errors may be emitted (eg when we write files). Just thought that as a bridge to v3 we could provide that context as a log instead. |
WSH032
force-pushed
the
fix/deep-link-semver
branch
from
93bcfce to
cd9dcb5
Compare
My bad, I missed those. Done. |
Package Changes Through cd9dcb5There are 8 changes which include dialog with minor, dialog-js with minor, deep-link with patch, deep-link-js with patch, log with minor, log-js with minor, updater with minor, updater-js with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
refer to #2928 (comment)
@FabianLars Can we release a patch version as soon as possible? This issue caused the pytauri v0.8 release yesterday to be interrupted at the final stage.
Building on Windows results in differences in
**/schema.json(different newline), any ideas? I'm concerned this might once again cause issue： tauri-apps/tauri#13597